feat: add helm chart by heliapb · Pull Request #161 · perses/perses-operator

heliapb · 2025-05-30T10:31:58Z

From issue #79
Add helm chart using kubebuilder helm plugin

.gitignore

dougkirkley · 2025-05-30T11:45:48Z

This issue could be a good way to test the full helm chart and installing custom resources as well, in a separate PR

dougkirkley · 2025-06-06T15:01:23Z

@heliapb Do you think your could load the current perses-operator docker image into kind and use that to test this scenario?

ibakshay

Thank you very much for this PR! Left few comments :)

ibakshay · 2025-06-10T15:30:54Z

Makefile

+##@ Helm
+.PHONY: helm-chart
+helm-chart: manifests
+	kubebuilder edit --plugins=helm/v1-alpha


It will be great if the kubebuilder binary can be installed locally instead of installing it globally by the end-user in advance. Please see how it is done for [jsonnet_binary here](https://github.com/perses/perses-operator/blob/main/Makefile#L316-L320.

Hi thanks for the feedback, will try to pick up this work again

ibakshay · 2025-06-10T15:35:06Z

.github/workflows/test-chart.yml

+
+      - name: Check Helm release
+        run: |
+          helm status perses-operator --namespace perses-operator-system


We also need to have a workflow to release this helm chart. Same like this one

ibakshay · 2025-06-10T15:37:10Z

dist/chart/Chart.yaml

+type: application
+version: 0.1.0
+appVersion: "0.1.0"
+icon: "https://example.com/icon.png"


Suggested change

icon: "https://example.com/icon.png"

icon: "https://github.com/perses/perses/blob/main/docs/images/perses_logo_lt.png"

Skaronator · 2025-07-30T11:31:54Z

I think it would be cool to provide a "Installing Perses in Kubernetes" documentation in perses docs?

https://perses.dev/perses/docs/installation/in-a-container/

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>

Skaronator · 2025-07-31T06:22:48Z

dist/chart/values.yaml

+metrics:
+  enable: true
+
+# [PROMETHEUS]: To enable a ServiceMonitor to export metrics to Prometheus set true
+prometheus:
+  enable: false
+


Naming this metrics.enable and prometheus.enable might be really confusing. I would just nest it similar to other helm charts that I have used.

Suggested change

metrics:

enable: true

# [PROMETHEUS]: To enable a ServiceMonitor to export metrics to Prometheus set true

prometheus:

enable: false

metrics:

enable: true

# To enable a ServiceMonitor to export metrics to Prometheus set true

serviceMonitor:

enable: false

Skaronator · 2025-07-31T09:12:38Z

Personally I would put the helm chart in charts/perses-operator and not in dist/chart so it aligns more with the common chart structure of other helm chart repositories. Even though we only have on chart here.

Skaronator · 2025-07-31T09:20:52Z

dist/chart/values.yaml

+  container:
+    image:
+      repository: controller
+      tag: latest


This should remain empty and the actual deployment.yaml Template should fallback to the AppVersion defined in Chart.yaml.

Thats also how helm recommend it when you run helm create xy

Skaronator · 2025-07-31T09:22:13Z

dist/chart/templates/manager/manager.yaml

+            {{- end }}
+          command:
+            - /manager
+          image: {{ .Values.controllerManager.container.image.repository }}:{{ .Values.controllerManager.container.image.tag }}


As mentioned below/above. The image.tag should use .Chart.AppVersion by default and values should be empty.

This example is from helm create xy

image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"

Skaronator · 2025-07-31T09:25:19Z

dist/chart/values.yaml

+  replicas: 1
+  container:
+    image:
+      repository: controller


Suggested change

repository: controller

repository: docker.io/persesdev/perses-operator

Skaronator · 2025-07-31T09:46:07Z

dist/chart/templates/manager/manager.yaml

+          command:
+            - /manager


/manager doesn't exist in docker.io/persesdev/perses-operator:latest. I would suggest to allow users to overwrite it but keep it empty by default. No need to overwrite the default entrypoint in the container image.

Something like this (untested)

Suggested change

command:

- /manager

{{ with .Values.controllerManager.container.command }}

command: {{ . | toYaml | nindent 8 }}

{{ end }}

Skaronator · 2025-07-31T09:47:20Z

dist/chart/values.yaml

+    resources:
+      limits:
+        cpu: 500m
+        memory: 128Mi
+      requests:
+        cpu: 10m
+        memory: 64Mi


This should not be set by default. Keep it empty:

resources: {}

Skaronator · 2025-08-30T10:12:39Z

I just noticed that there is already a dedicated helm chart repository here: https://github.com/perses/helm-charts

So it would make sense to put the operator helm chart there as well.

ibakshay · 2025-08-30T11:21:39Z

I just noticed that there is already a dedicated helm chart repository here: https://github.com/perses/helm-charts

So it would make sense to put the operator helm chart there as well.

Please have a look at this comment for context - #79 (comment)

slashpai · 2026-02-26T17:49:25Z

@heliapb Will the helm chart be in https://github.com/perses/helm-charts?

my bad just saw #79 (comment)

heliapb · 2026-02-26T17:57:32Z

@heliapb Will the helm chart be in https://github.com/perses/helm-charts?

my bad just saw #79 (comment)

Ah I'm sorry I've forgotten about this PR. I might close for now as I don't have a lot of time nowadays. In case someone else might want to pick this

heliapb force-pushed the feat/helm_chart branch from d9e6331 to 8c55c67 Compare May 30, 2025 10:39

dougkirkley reviewed May 30, 2025

View reviewed changes

.gitignore Show resolved Hide resolved

heliapb force-pushed the feat/helm_chart branch 2 times, most recently from 4f1ac25 to 5921f90 Compare May 30, 2025 11:14

heliapb force-pushed the feat/helm_chart branch from ab471b9 to 1a3071e Compare May 30, 2025 13:13

ibakshay reviewed Jun 10, 2025

View reviewed changes

heliapb closed this Jul 30, 2025

heliapb force-pushed the feat/helm_chart branch from 1a3071e to c5719c2 Compare July 30, 2025 13:11

feat: helm

5c3ed6d

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>

heliapb reopened this Jul 30, 2025

Skaronator reviewed Jul 31, 2025

View reviewed changes

Skaronator suggested changes Jul 31, 2025

View reviewed changes

Skaronator reviewed Jul 31, 2025

View reviewed changes

heliapb closed this Feb 26, 2026

	icon: "https://example.com/icon.png"
	icon: "https://github.com/perses/perses/blob/main/docs/images/perses_logo_lt.png"

	repository: controller
	repository: docker.io/persesdev/perses-operator

-          command:
-            - /manager
+          {{ with .Values.controllerManager.container.command }}
+          command: {{ . | toYaml | nindent 8 }}
+          {{ end }}

Conversation

heliapb commented May 30, 2025

Uh oh!

Uh oh!

dougkirkley commented May 30, 2025

Uh oh!

dougkirkley commented Jun 6, 2025

Uh oh!

ibakshay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skaronator commented Jul 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skaronator commented Jul 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skaronator commented Aug 30, 2025

Uh oh!

ibakshay commented Aug 30, 2025

Uh oh!

slashpai commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

heliapb commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

slashpai commented Feb 26, 2026 •

edited

Loading